Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context on callbacks #20

Open
t-persson opened this issue May 28, 2020 · 0 comments
Open

Remove context on callbacks #20

t-persson opened this issue May 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@t-persson
Copy link
Collaborator

Description

We always call the callbacks with the event object and the context in which this event was sent.
This is a legacy feature that was used when prototyping the eiffellib and should be removed as it does not serve any really good purpose other than clutter in the callbacks.

Note that we need to start by deprecating it and then remove it.

Motivation

I have found no need for this feature at all and I don't see any real need for it anywhere else.
If there is a need for something like this, then we should instead add a utility module to eiffellib.
For example a function for fetching a link value from an event (get_link("context")).

Exemplification

Less unnecessary clutter in callbacks.

Benefits

Less unnecessary clutter in callbacks.

Possible Drawbacks

Removing this outright will break a lot of tools that rely on it.

@t-persson t-persson added the enhancement New feature or request label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant