You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason, internal/database/drivers/mongodb.Database.GetEvents just ignores any errors returned from a Find call on a collection or All called on a cursor. In the latter case we log the error (at the info level) but then just happily continue to the next collection. This could result in a query happily but incorrectly returning zero results.
Motivation
Errors need to propagate to clients to allow them to retry later or at least be aware that something happened. In this case we're not even logging the error returned from Find so we can end up in some very hard to debug situations.
Exemplification
N/A
Benefits
No risk of returning empty or incomplete results when a query error occurs.
Possible Drawbacks
None.
The text was updated successfully, but these errors were encountered:
Description
For some reason, internal/database/drivers/mongodb.Database.GetEvents just ignores any errors returned from a Find call on a collection or All called on a cursor. In the latter case we log the error (at the info level) but then just happily continue to the next collection. This could result in a query happily but incorrectly returning zero results.
Motivation
Errors need to propagate to clients to allow them to retry later or at least be aware that something happened. In this case we're not even logging the error returned from Find so we can end up in some very hard to debug situations.
Exemplification
N/A
Benefits
No risk of returning empty or incomplete results when a query error occurs.
Possible Drawbacks
None.
The text was updated successfully, but these errors were encountered: