-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator: Implement Composition as abstract class to inherit redundant fields for other Compositions #94
Comments
I think we can have an AbstractComposition in the shared package that all generated Composition DTOs inherit from. |
+1 I would appreciate if we might have this abstract Composition class. |
One additional comment, it might be interesting to update the CompositionEndpoint:
|
This depends on the Composition, if we have fields that are contained in every Composition, because of the Reference Model, it is better to use an Abstract Class (if not we have to duplicate them). If not i agree on the solution above. |
Fixed in #153 which will become release 1.0.0 |
Background
Currently many of the generated Compositions contain duplicated fields like Language, these Attributes could be contained by a root class Composition, which makes specific Compositions smaller and allows easier handling of Compositions when programming. Especially when in general Compositions are to be referenced.
Acceptance criteria
Implement (abstract) class Composition that contains all Attributes that are standard to every Composition.
Success criteria
The text was updated successfully, but these errors were encountered: