You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the issue is created to mainly address the issues of the library post iOS 14, while these issues in general can be addressed by creating the fork and correcting them there. I still believe that it is better to address it here.
Firstly, I would like to address that the library should really split its implementations for the iOS 9 and iOS 14. It is because the implementation loses clarity. For instance, the library creates, manages and updates _UICustomBlurEffect which does not affect anything on iOS 14.
/// Returns the instance of UIBlurEffect.
private let blurEffect = (NSClassFromString("_UICustomBlurEffect") as! UIBlurEffect.Type).init()
Mainly due to the first issue, input variables aren't clear to end user. For instance, colorTint is sufficient post iOS 14, because it directly uses alpha from UIColor, e.g.
At the same time, scale doesn't have any effect and still it is present in parameters of the SwiftUI view.
Finally, the view automatically increases the saturation, which has appeared in several issues. It can be observed by accessing backdropView?.value(forKey: "filters") which is
Hi,
the issue is created to mainly address the issues of the library post iOS 14, while these issues in general can be addressed by creating the fork and correcting them there. I still believe that it is better to address it here.
Firstly, I would like to address that the library should really split its implementations for the iOS 9 and iOS 14. It is because the implementation loses clarity. For instance, the library creates, manages and updates _UICustomBlurEffect which does not affect anything on iOS 14.
Mainly due to the first issue, input variables aren't clear to end user. For instance,
colorTint
is sufficient post iOS 14, because it directly uses alpha from UIColor, e.g.At the same time,
scale
doesn't have any effect and still it is present in parameters of the SwiftUI view.Finally, the view automatically increases the saturation, which has appeared in several issues. It can be observed by accessing
backdropView?.value(forKey: "filters")
which isBy setting value of
inputAmount
to 1, the blur view wouldn't oversaturate background and VisualEffectView would behave as actual blur.Thanks.
P.S. For instance, the implementation can be reduced to
Reduced implementation without saturation
The text was updated successfully, but these errors were encountered: