Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this work properly with in-repo-addons #38

Closed
Awem opened this issue Jun 11, 2015 · 6 comments
Closed

Make this work properly with in-repo-addons #38

Awem opened this issue Jun 11, 2015 · 6 comments

Comments

@Awem
Copy link

Awem commented Jun 11, 2015

I haven't found a solution to make the following case work:

  1. Have ember-browserify installed via main package.json of the Ember-CLI-app
  2. Install a Node module via package.json of an in-repo-addon
  3. do import Module from "npm:module" in a file of the in-repo-addon

Result: Cannot find module

However, the same import command works, if you do not install that Node module via the in-repo-addon's but via the app's package.json.
One would need to somehow specify the path to the in-repo-addon's Node modules, but I haven't found a way to do that.

@asakusuma
Copy link
Collaborator

Have you tried installing ember-browserify in the addon as well? Git repo structure should not have an effect, as long as the directory structure is the same.

@Awem
Copy link
Author

Awem commented Jun 12, 2015

No, I will try that. It might work, but I would prefer to use the main app's ember-browserify.

@Awem
Copy link
Author

Awem commented Jun 16, 2015

Installing ember-browserify in the addon as well, doesn't make a difference. I ran in a new issue, though: #39

@asakusuma
Copy link
Collaborator

@AW-UC were you able to get this working by installing the module in the root app?

@Awem
Copy link
Author

Awem commented Jul 21, 2015

yes, installing the module in the root app works well. Only the combination of:

  1. module in in-repo-addon
  2. ember-browserify in root app
    doesn't work.

@asakusuma
Copy link
Collaborator

Yes I believe that is expected. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants