Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow pass through of node env without setting target to node #4

Merged
merged 1 commit into from
Apr 11, 2019
Merged

fix: allow pass through of node env without setting target to node #4

merged 1 commit into from
Apr 11, 2019

Conversation

abutterworth
Copy link
Contributor

Changing the webpack target to node is unneeded to pass through NODE_ENV from a consuming app. This approach is better and discussed here: webpack/webpack#6673

@abutterworth abutterworth requested a review from robrap April 10, 2019 21:36
@abutterworth abutterworth merged commit 4b48e5a into master Apr 11, 2019
@stvstnfrd stvstnfrd deleted the abutterworth/pass-through-node-env branch June 2, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abutterworth @robrap