Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module: Refactor SecrectStoreClient from edgex-go to SecretStoreManagementClient in go-mod-secrets #87

Closed
lenny-goodell opened this issue Jan 28, 2021 · 0 comments · Fixed by #91
Closed

Module: Refactor SecrectStoreClient from edgex-go to SecretStoreManagementClient in go-mod-secrets #87

lenny-goodell opened this issue Jan 28, 2021 · 0 comments · Fixed by #91
Assignees
@lenny-goodell
Labels
3-high priority denoting release-blocking issues security-services tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Milestone
Ireland

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Jan 28, 2021 •
edited
Loading

Current SecrectStoreClient in edgex-go should be part of the Secrets abstraction in go-mod-secrets. Still should be a separate interface (SecrectStoreManagementClient) from the existing one in go-mod-secrets.

Vault implementation should be added to the existing vault implementation.

Abstraction also needs to be refactored, more, to not leak that Vault is the implementation
@lenny-goodell lenny-goodell self-assigned this Jan 28, 2021
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues security-services labels Jan 28, 2021
@lenny-goodell lenny-goodell added this to the Ireland milestone Jan 28, 2021
@lenny-goodell lenny-goodell added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label Jan 28, 2021
lenny-goodell referenced this issue in lenny-goodell/go-mod-secrets Feb 18, 2021
refactor: Refactor to be proper abastraction of a SecretStore
89e0dcb 
No longer leak that Vault is the only implementation
Add Type to the configuration and factory method, so it will error if not set
Move SecretStore client from edgex-go in to this abstraction
Now have to interfaces that the vault wrapper implements, which are SecretsClient & SecretStoreClient

closes #87

BREAKING CHANGE: All existing SecretStore configuration must add `Type = 'vault'`

Signed-off-by: lenny <[email protected]>
This was referenced Feb 18, 2021
Closed
Closed
lenny-goodell referenced this issue in lenny-goodell/go-mod-secrets Feb 18, 2021
refactor: Refactor to be proper abstraction of a SecretStore
b0c6237 
No longer leak that Vault is the only implementation
Add Type to the configuration and factory method, so it will error if not set
Move SecretStore client from edgex-go in to this abstraction
Now have to interfaces that the vault wrapper implements, which are SecretsClient & SecretStoreClient

closes #87

BREAKING CHANGE: All existing SecretStore configuration must add `Type = 'vault'`

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/go-mod-secrets Feb 18, 2021
refactor: Refactor to be proper abstraction of a SecretStore
886854b 
No longer leak that Vault is the only implementation
Add Type to the configuration and factory method, so it will error if not set
Move SecretStore client from edgex-go in to this abstraction
Now have to interfaces that the vault wrapper implements, which are SecretsClient & SecretStoreClient

closes #87

BREAKING CHANGE: All existing SecretStore configuration must add `Type = 'vault'`

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell mentioned this issue Feb 18, 2021
Merged
13 tasks
lenny-goodell referenced this issue in lenny-goodell/go-mod-secrets Feb 18, 2021
refactor: Refactor to be proper abstraction of a SecretStore
7a84eec 
No longer leak that Vault is the only implementation
Add Type to the configuration and factory method, so it will error if not set
Move SecretStore client from edgex-go in to this abstraction
Now have to interfaces that the vault wrapper implements, which are SecretsClient & SecretStoreClient

closes #87

BREAKING CHANGE: All existing SecretStore configuration must add `Type = 'vault'`

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/go-mod-secrets Feb 18, 2021
refactor: Refactor to be proper abstraction of a SecretStore
89b3b67 
No longer leak that Vault is the only implementation
Added `Type` to the configuration and factory method, so it will error if not set
Move SecretStoreClient from edgex-go in to this abstraction and added the `EnableConsulSecretEngine` interface needed for `Secure Consul`
Now have to interfaces that the vault wrapper implements, which are SecretsClient & SecretStoreClient

closes #87

BREAKING CHANGE: All existing SecretStore configuration must add `Type = 'vault'`

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell linked a pull request Feb 18, 2021 that will close this issue
refactor: Rework to be proper abstraction of a SecretStore and add SecretStoreClient from edgex-go #91
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
3-high priority denoting release-blocking issues security-services tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Milestone
Ireland
1 participant
@lenny-goodell