-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional "parent" field to Device objects. #887
feat: Add optional "parent" field to Device objects. #887
Conversation
Also add DeviceClient function to query a tree of devices. Signed-off-by: Corey Mutter <[email protected]>
…ontracts into feat/4769-add-parent-device-field
Signed-off-by: Corey Mutter <[email protected]>
Signed-off-by: Corey Mutter <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 62.32% 64.25% +1.93%
==========================================
Files 93 93
Lines 3679 3696 +17
==========================================
+ Hits 2293 2375 +82
+ Misses 1164 1100 -64
+ Partials 222 221 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Corey Mutter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eaton-coreymutter the device client mock should be regenerated, or we will get the unit test failure in other services |
These updates were missed in edgexfoundry#887 and edgexfoundry#886. Signed-off-by: Jack Chen <[email protected]>
[2024-04-23T04:16:06.573Z] --- FAIL: TestAddReadingTags (0.00s) fixed in #889 |
Sorry about that - I regenerated it once but forgot to do it again after changing the signature. |
no problem |
Related to issue edgexfoundry/edgex-go#4769 but does not close it, other PRs to come.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Docs to update are in edgex-go (the OpenAPIs), will update those in another PR for this issue
Testing Instructions
I built core-metadata, core-command, device-virtual with these changes, verified I could set the "parent" field via PATCH or via inclusion in YAML device definition file, the field can be set to empty via PATCH with empty-string value, and the field persists across restarts of core-metadata.
New Dependency Instructions (If applicable)