-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add openziti to core contracts #876
Conversation
Signed-off-by: dovholuknf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help make sure the unit test are all passed
[2024-02-01T03:30:52.756Z] ? github.com/edgexfoundry/go-mod-core-contracts/v3/clients [no test files]
[2024-02-01T03:30:58.022Z] # github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http [github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http.test]
[2024-02-01T03:30:58.022Z] clients/http/authinjector_test.go:19:9: cannot use &emptyAuthenticationInjector{} (value of type *emptyAuthenticationInjector) as interfaces.AuthenticationInjector value in return statement: *emptyAuthenticationInjector does not implement interfaces.AuthenticationInjector (missing method RoundTripper)
[2024-02-01T03:30:58.022Z] FAIL github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http [build failed]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once unit test is fixed
Signed-off-by: dovholuknf <[email protected]>
The interface was not satisfied as I'd changed it. I've pushed a fix out that should hopefully fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: dovholuknf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uses the authInjector to set the RoundTripper to use when making requests. Necessary to integrate with OpenZiti. See go-mod-bootstrapper at https://github.com/edgexfoundry/go-mod-bootstrap
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
This is a sweeping change that crosses numerous repos. I don't know how to effectively answer this particular question and this one change is insufficient for testing. A larger, cross-cutting PR/effort is needed to put all the pieces together. I could use help with knowing how to satisfy this
New Dependency Instructions (If applicable)
none