Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openziti to core contracts #876

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

dovholuknf
Copy link
Contributor

Uses the authInjector to set the RoundTripper to use when making requests. Necessary to integrate with OpenZiti. See go-mod-bootstrapper at https://github.com/edgexfoundry/go-mod-bootstrap

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • [x ] I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

This is a sweeping change that crosses numerous repos. I don't know how to effectively answer this particular question and this one change is insufficient for testing. A larger, cross-cutting PR/effort is needed to put all the pieces together. I could use help with knowing how to satisfy this

New Dependency Instructions (If applicable)

none

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help make sure the unit test are all passed

[2024-02-01T03:30:52.756Z] ? github.com/edgexfoundry/go-mod-core-contracts/v3/clients [no test files]
[2024-02-01T03:30:58.022Z] # github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http [github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http.test]
[2024-02-01T03:30:58.022Z] clients/http/authinjector_test.go:19:9: cannot use &emptyAuthenticationInjector{} (value of type *emptyAuthenticationInjector) as interfaces.AuthenticationInjector value in return statement: *emptyAuthenticationInjector does not implement interfaces.AuthenticationInjector (missing method RoundTripper)
[2024-02-01T03:30:58.022Z] FAIL github.com/edgexfoundry/go-mod-core-contracts/v3/clients/http [build failed]

lenny-goodell
lenny-goodell previously approved these changes Feb 5, 2024
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once unit test is fixed

@dovholuknf
Copy link
Contributor Author

The interface was not satisfied as I'd changed it. I've pushed a fix out that should hopefully fix it

@dovholuknf dovholuknf requested a review from cloudxxx8 February 27, 2024 19:17
lenny-goodell
lenny-goodell previously approved these changes Feb 27, 2024
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 22d5e16 into edgexfoundry:main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants