feat: Move the common middlewares to go-mod-bootstrap #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnevis-i
requested changes
Jul 25, 2023
bnevis-i
reviewed
Jul 25, 2023
Closes edgexfoundry#565. - Define the common middleware funcs on the router level. - Skip Ping in the auth handler func. Signed-off-by: Lindsey Cheng <[email protected]>
Return next handlerFunc for Ping instead of nil in VaultAuthenticationHandlerFunc. Signed-off-by: Lindsey Cheng <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 58.68% 58.75% +0.06%
==========================================
Files 29 30 +1
Lines 2418 2468 +50
==========================================
+ Hits 1419 1450 +31
- Misses 907 922 +15
- Partials 92 96 +4
|
Revert back to invoke authenticationHook on the route level instead of on the server router level. Signed-off-by: Lindsey Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)