Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): do not use shared DefaultRegistry and fix wg.Done call #543

Merged
merged 1 commit into from
May 15, 2023

Conversation

ajcasagrande
Copy link
Contributor

@ajcasagrande ajcasagrande commented May 12, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
    I have only fully tested via the unit tests, and not under a real working scenario
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

  • checkout current main branch
  • run: go test github.com/edgexfoundry/go-mod-bootstrap/v3/bootstrap/metrics -test.count 10
  • expect FAIL
  • checkout this PR
  • run go test github.com/edgexfoundry/go-mod-bootstrap/v3/bootstrap/metrics -test.count 10
  • expect PASS

New Dependency Instructions (If applicable)

I have verified that this Fixes #458 on my local machine

@codecov-commenter
Copy link

Codecov Report

Merging #543 (7010ea7) into main (4bbc8c1) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   57.32%   57.32%           
=======================================
  Files          27       27           
  Lines        2219     2219           
=======================================
  Hits         1272     1272           
  Misses        865      865           
  Partials       82       82           
Impacted Files Coverage Δ
bootstrap/metrics/manager.go 89.42% <100.00%> (ø)

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 requested a review from lenny-goodell May 15, 2023 05:17
@lenny-goodell lenny-goodell merged commit 4aa258a into edgexfoundry:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test sometimes fails on Jenkins due to the concurrency error
4 participants