Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement IsRegistered to metrics manager #446

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

marcpfuller
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

@marcpfuller marcpfuller changed the title Is registered fix fix: implement Isregistered to metrics manager Feb 21, 2023
fixes: edgexfoundry/app-functions-sdk-go:1320

Signed-off-by: Marc-Philippe Fuller <[email protected]>
@lenny-goodell
Copy link
Member

@marcpfuller , in respect to this module, this is a new feature, not a fix. Please update the commit message and PR title.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once commit & PR tile are updated

@marcpfuller marcpfuller changed the title fix: implement Isregistered to metrics manager feat: implement Isregistered to metrics manager Feb 22, 2023
@lenny-goodell lenny-goodell changed the title feat: implement Isregistered to metrics manager feat: implement IsRegistered to metrics manager Feb 22, 2023
@lenny-goodell lenny-goodell added the enhancement New feature or request label Feb 22, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Feb 22, 2023
@lenny-goodell lenny-goodell merged commit 8ddd9e2 into edgexfoundry:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants