Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move configuration location code to public helper function #422

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented Jan 24, 2023

Signed-off-by: Elizabeth J Lee [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) - NA refactor
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) - NA refactor
  • I have opened a PR for the related docs change (if not, why?) - NA refactor

Testing Instructions

New Dependency Instructions (If applicable)

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 7c7ee01 into edgexfoundry:main Jan 24, 2023
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Jan 24, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants