bug(config): Embedded types do not work with package we use to pull from Consul #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom Consul Replaced embeded type vault.SecretConfig with copy of the fields from the type. closes #37 Signed-off-by: lenny <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 49.72% 49.72%
=======================================
Files 7 7
Lines 179 179
=======================================
Hits 89 89
Misses 89 89
Partials 1 1Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced embedded type vault.SecretConfig with copy of the fields from the type.
closes #37