Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dependency of github.com/BurntSushi/toml #208

Closed
cloudxxx8 opened this issue Apr 13, 2021 · 1 comment · Fixed by #209
Closed

Remove the dependency of github.com/BurntSushi/toml #208

cloudxxx8 opened this issue Apr 13, 2021 · 1 comment · Fixed by #209
Assignees
@lenny-goodell
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds

Comments

@cloudxxx8
Copy link
Member

In go.mod, there are two toml related libraries: github.com/BurntSushi/toml and github.com/pelletier/go-toml
I believe we can use only one.

In https://github.com/BurntSushi/toml, it states THIS PROJECT IS UNMAINTAINED
@cloudxxx8 cloudxxx8 added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label Apr 13, 2021
@lenny-goodell
Copy link
Member

Agreed, I just verified that the one location we use BurntSushi/toml can be replaced with using pelletier/go-toml to un-marshal the contents of the TOML file. I run a full execution test to verify.

@lenny-goodell lenny-goodell self-assigned this Apr 13, 2021
lenny-goodell referenced this issue in lenny-goodell/go-mod-bootstrap Apr 13, 2021
refactor: Replace use of BurntSushi/toml with pelletier/go-toml
6c8f2b4 
closes #208

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell mentioned this issue Apr 13, 2021
Merged
6 tasks
@lenny-goodell lenny-goodell linked a pull request Apr 13, 2021 that will close this issue
refactor: Replace use of BurntSushi/toml with pelletier/go-toml #209
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Replace use of BurntSushi/toml with pelletier/go-toml lenny-goodell/go-mod-bootstrap
2 participants
@cloudxxx8 @lenny-goodell