feat(sdk): Use v2 Command Client #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 62.79% 62.77% -0.02%
==========================================
Files 31 31
Lines 1981 1980 -1
==========================================
- Hits 1244 1243 -1
Misses 647 647
Partials 90 90
Continue to review full report at Codecov.
|
lenny-goodell
requested changes
May 19, 2021
| @@ -63,10 +63,10 @@ func NotificationsClientFrom(get di.Get) notifications.NotificationsClient { | |||
| var CommandClientName = di.TypeInstanceToName((*command.CommandClient)(nil)) | |||
There was a problem hiding this comment.
change command.CommandClient to interfaces.CommandClient
Register v2 client in dic and change interface used throughout. Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse
force-pushed
the
v2-command-client
branch
from
22ed9b3 to
89e9755
Compare
lenny-goodell
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register v2 client in dic and change interface used throughout.
Signed-off-by: Alex Ullrich [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
v1 client is still exposed to custom services by the SDK, does not work with commands routed to v2 device services.
Issue Number: #844
What is the new behavior?
v2 client is registered with dic and interface used in references throughout.
Does this PR introduce a breaking change?
Yes this will break any usages of the client retrieved through context.CommandClient() by returning a new interface.
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
I updated the mocks by hand since I didn't want to worry about mockery version or usage differences messing something up.
Other information