Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch to 2.0 Consul path #782

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: lenny [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently use /1.0/ path hard code in the SDK

Issue Number: #768

What is the new behavior?

Now using the /2.0/ path set by go-mod-bootstrap

Does this PR introduce a breaking change?

  • Yes
  • No

BREAKING CHANGE: Consul configuration now under the /2.0/ path

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

closes #768

BREAKING CHANGE: Consul configuration now under the `/2.0/` path

Signed-off-by: lenny <[email protected]>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit da3d051 into edgexfoundry:master Apr 6, 2021
@lenny-goodell lenny-goodell deleted the config-version branch April 6, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants