Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove V1 API code and swagger #730

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

V1 Api code and swagger exist

Issue Number: #720

What is the new behavior?

V1 Api code and swagger no longer exist
Also reworked V2 code to remove v2 in paths

Does this PR introduce a breaking change?

  • Yes
  • No

BREAKING CHANGE: V1 API's no longer supported

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Also reworked V2 code to remove `v2` in paths

closes #720

BREAKING CHANGE: V1 API's no longer supported

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell linked an issue Mar 4, 2021 that may be closed by this pull request
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny tweaks

@codecov-io
Copy link

Codecov Report

Merging #730 (dcf9c76) into master (4a1f060) will decrease coverage by 1.34%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   64.64%   63.30%   -1.35%     
==========================================
  Files          32       32              
  Lines        2110     2060      -50     
==========================================
- Hits         1364     1304      -60     
- Misses        652      664      +12     
+ Partials       94       92       -2     
Impacted Files Coverage Δ
internal/trigger/http/rest.go 6.97% <ø> (+0.15%) ⬆️
pkg/transforms/conversion.go 80.95% <ø> (ø)
internal/webserver/server.go 37.50% <33.33%> (-38.50%) ⬇️
internal/controller/rest/controller.go 84.84% <100.00%> (ø)
internal/webserver/types.go 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1f060...dcf9c76. Read the comment docs.

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but build failed

@lenny-goodell lenny-goodell merged commit 7e0294b into edgexfoundry:master Mar 4, 2021
@lenny-goodell lenny-goodell deleted the remove-v1-api branch March 4, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK: Remove V1 API code and swagger
3 participants