refactor: Rework secrets for HTTP Export so value in InsecureSecrets can be overridden #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
http-secret
branch
2 times, most recently
from
81cd4f7 to
c6ffff8
Compare
…can be overridden closes #521 BREAKING CHANGE: Parameters have changed for HTTP Post/Put with SecretHeader Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
http-secret
branch
from
c6ffff8 to
23c0d55
Compare
AlexCuse
previously approved these changes
Feb 24, 2021
…feedback Signed-off-by: lenny <[email protected]>
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SecretHeaderName used as key for InsecureSecrets is dynamic so can not be overridden in the 'http-export' profile which just has a place holder.
Issue Number: #521
What is the new behavior?
Now the key in InsecureSecrets can be fixed in the 'http-export' profile since is is not also used as the HTTP Header Name.
This allows for the header value stored in InsecureSecrets to be overridden with environment variable.
Does this PR introduce a breaking change?
BREAKING CHANGE: Parameters have changed for HTTP Post/Put with SecretHeader
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information