feat(sdk): Add MakeItStop #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure that the test failure is not related to my change. Is there an easy-ish way to run the arm64 tests without access to an arm64 system? |
lenny-goodell
previously approved these changes
Jan 7, 2021
|
Cool I will rebase right now. If you want to assign documentation issue to me I will knock it out tomorrow @lenny-intel |
AlexCuse
force-pushed
the
sdk-stop
branch
2 times, most recently
from
ebe1c98 to
5793c06
Compare
4 tasks
Store reference on the sdk to a CancelFunc created in MakeItRun and expose to enable clean programmatic exits. Signed-off-by: Alex Ullrich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 60.90% 60.81% -0.09%
==========================================
Files 31 31
Lines 1798 1807 +9
==========================================
+ Hits 1095 1099 +4
- Misses 630 635 +5
Partials 73 73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store reference on the sdk to a CancelFunc created in MakeItRun and
expose to enable clean programmatic exits.
Signed-off-by: Alex Ullrich [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently there is no way to exit the service programmatically.
Issue Number:
#612
What is the new behavior?
Adds a MakeItStop method to the sdk instance that allows calling a cancel function managed by MakeItRun.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
No
Other information