Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-forward): Remove Mongo as supported DB option #589

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Mongo is a supported DB for Store and Forward

Issue Number: #395

What is the new behavior?

Mongo is no longer a supported DB for Store and Forward

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell linked an issue Dec 7, 2020 that may be closed by this pull request
This is a backwards compatability breaking change

closes #395

Signed-off-by: lenny <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #589 (5a26abf) into master (e5100d5) will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   61.00%   60.50%   -0.50%     
==========================================
  Files          42       41       -1     
  Lines        2208     2175      -33     
==========================================
- Hits         1347     1316      -31     
+ Misses        773      772       -1     
+ Partials       88       87       -1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5100d5...5a26abf. Read the comment docs.

@lenny-goodell lenny-goodell merged commit d5e638f into edgexfoundry:master Dec 7, 2020
@lenny-goodell lenny-goodell deleted the remove-mongo branch December 7, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mongo code
3 participants