feat: Add ability to export via HTTP PUT with secret header support #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
rsdmike,
eno-intel,
adam-intel,
brian-intel and
jim-wang-intel
lenny-goodell
force-pushed
the
http-put
branch
from
6104d07 to
26f67bf
Compare
Added the new HTTPPut pipeline function. Refactored common code into helper closes #516 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
http-put
branch
from
26f67bf to
cb25ad2
Compare
jim-wang-intel
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
HTTP Export only allowed POST to the target URL via the HTTPPost pipeline function.
Issue Number: #516
What is the new behavior?
HTTP Export allows POST & PUT to the target URL via the HTTPPost & HTTPPut pipeline functions.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information