fix(triggers): MQTT subscribe via onConnect handler so re-subscribe on auto-reconnect #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
changed the title
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 64.65% 61.81% -2.85%
==========================================
Files 35 42 +7
Lines 2105 2163 +58
==========================================
- Hits 1361 1337 -24
- Misses 663 739 +76
- Partials 81 87 +6
Continue to review full report at Codecov.
|
lenny-goodell
requested review from
brian-intel,
cloudxxx8,
chr1shung and
weichou1229
jim-wang-intel
requested changes
Oct 14, 2020
adam-intel
previously approved these changes
Oct 14, 2020
…n reconnects closes #531 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
onConnect
branch
from
d729115 to
cb3a60d
Compare
jim-wang-intel
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Topic not re-subscribed to when auto reconnect occurs
Issue Number: #531
What is the new behavior?
Topic is subscribed to after any connect, initial or auto
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information