Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consume new -d/--dev Dev Mode command-line flag #1397

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Apr 26, 2023

Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the Host settings pulled from common configuration to be overridden with the value localhost.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document new -d/--dev command-line flag edgex-docs#1040

Testing Instructions

From latest Compose Builder run make run no-secty ds-virtual
run make build from this branch
run the app template with just -cp flag
Verify the following error

"Unable to get version of Core Metadata: failed to send a http request -> Get \"http://edgex-core-metadata:59881/api/v3/version\": dial tcp: lookup edgex-core-metadata on 8.8.8.8:53: no such host"

run the app template with just -cp -d flags
Verify no errors
Enable DEBUG logging from Consul
Verify service is receiving and processing events

New Dependency Instructions (If applicable)

Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the Host settings pulled from common configuration to be overridden with the value localhost.

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell requested review from marcpfuller and ejlee3 and removed request for marcpfuller April 26, 2023 18:58
@codecov-commenter
Copy link

Codecov Report

Merging #1397 (a8179ed) into main (fb33968) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files          36       36           
  Lines        3057     3057           
=======================================
  Hits         2045     2045           
  Misses        882      882           
  Partials      130      130           
Impacted Files Coverage Δ
internal/app/service.go 56.36% <0.00%> (ø)

@lenny-goodell lenny-goodell merged commit 199daa5 into edgexfoundry:main Apr 26, 2023
@lenny-goodell lenny-goodell deleted the dev-mode branch April 26, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants