refactor(sdk): implement error interface for MessageError #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: edgexfoundry#1125 Signed-off-by: Marc-Philippe Fuller <[email protected]>
marcpfuller
force-pushed
the
messageError_interface
branch
from
5c92b9b to
d8ea12a
Compare
lenny-goodell
requested changes
Jan 18, 2023
internal/runtime/runtime_test.go
Outdated
| @@ -269,8 +269,8 @@ func TestProcessMessageTransformError(t *testing.T) { | |||
| msgErr := runtime.ProcessMessage(context, messageData, runtime.GetDefaultPipeline()) | |||
|
|
|||
| require.NotNil(t, msgErr, "Expected an error") | |||
There was a problem hiding this comment.
This one can now be removed.
There was a problem hiding this comment.
require.NotNil has been removed
internal/runtime/runtime_test.go
Outdated
| @@ -449,7 +449,7 @@ func TestDecode_Process_MessageTargetType(t *testing.T) { | |||
| targetData, err, _ := runtime.DecodeMessage(context, envelope) | |||
| if currentTest.ErrorExpected { | |||
| assert.NotNil(t, err, fmt.Sprintf("expected an error for test '%s'", currentTest.Name)) | |||
There was a problem hiding this comment.
This one can now be removed.
There was a problem hiding this comment.
assert.NotNil has been removed
| @@ -82,6 +82,10 @@ type MessageError struct { | |||
| ErrorCode int | |||
| } | |||
|
|
|||
| func (merr *MessageError) Error() string { | |||
Signed-off-by: Marc-Philippe Fuller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1125
Signed-off-by: Marc-Philippe Fuller [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
make testNew Dependency Instructions (If applicable)