Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk)!: remove deprecated Process code #1240

Merged

Conversation

marcpfuller
Copy link
Contributor

@marcpfuller marcpfuller commented Dec 5, 2022

BRAKING CHANGE: remove deprecated Process code and MessageProcessor code, use MessageReceived

CLoses: #1227

Signed-off-by: Marc-Philippe Fuller [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) n/a
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    fix: remove deprecated code for MessageProcessor edgex-docs#925

Testing Instructions

make test

New Dependency Instructions (If applicable)

N/A

BRAKING CHANGE: remove deprecated Process code, use MessageReceived

CLoses: edgexfoundry#1227

Signed-off-by: Marc-Philippe Fuller <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #1240 (34a1126) into main (05fb931) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   66.78%   67.12%   +0.33%     
==========================================
  Files          39       39              
  Lines        3315     3297      -18     
==========================================
- Hits         2214     2213       -1     
+ Misses        957      940      -17     
  Partials      144      144              
Impacted Files Coverage Δ
internal/app/triggermessageprocessor.go 61.53% <ø> (+11.01%) ⬆️
internal/app/triggerfactory.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

BREAKING CHANGE: remove deprecated MessageProcessor code, use MessageReceived

Closes edgexfoundry#1227

Signed-off-by: Marc-Philippe Fuller <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member

@marcpfuller , please submit the DOC update PR for this and add as link above in the checklist.

@lenny-goodell lenny-goodell merged commit a81394e into edgexfoundry:main Jan 3, 2023
@lenny-goodell lenny-goodell changed the title refactor(sdk): remove deprecated Process code refactor(sdk)!: remove deprecated Process code Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General cleanup for deprecated trigger/pipelines APIs
4 participants