refactor(sdk): remove deprecated EncryptWithAES code

[marcpfuller]

BRAKING CHANGE: remove deprecated EncryptionWithAES code, use AESProtection

CLoses: #1227

Signed-off-by: Marc-Philippe Fuller [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

• I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
• I am not introducing a new dependency (add notes below if you are)
• I have added unit tests for the new feature or bug fix (if not, why?) N/A
• I have fully tested (add details below) this the new feature or bug fix (if not, why?)
• I have opened a PR for the related docs change (if not, why?)
  fix: remove references to deprecated code for EncryptWithAES edgex-docs#919

Testing Instructions

make test

New Dependency Instructions (If applicable)

N/A

[lenny-goodell]

@marcpfuller , this PR needs to be rebased and fix conflicts.
Also need corresponding Docs PR.

[bnevis-i]

@marcpfuller Failed test case

023-01-03T23:00:13.730Z] --- FAIL: TestEncrypt (0.00s)

[2023-01-03T23:00:13.730Z]     --- FAIL: TestEncrypt/Good_-_Key_&_vector_ (0.00s)

[2023-01-03T23:00:13.730Z]         configurable_test.go:422: 

[2023-01-03T23:00:13.730Z]             	Error Trace:	/w/workspace/dry_app-functions-sdk-go_PR-1235/internal/app/configurable_test.go:422

[2023-01-03T23:00:13.730Z]             	Error:      	Not equal: 

[2023-01-03T23:00:13.730Z]             	            	expected: false

[2023-01-03T23:00:13.730Z]             	            	actual  : true

[2023-01-03T23:00:13.730Z]             	Test:       	TestEncrypt/Good_-_Key_&_vector_

[2023-01-03T23:00:13.730Z]     --- FAIL: TestEncrypt/Good_-_Secrets_&_vector (0.00s)

[2023-01-03T23:00:13.730Z]         configurable_test.go:422: 

[2023-01-03T23:00:13.730Z]             	Error Trace:	/w/workspace/dry_app-functions-sdk-go_PR-1235/internal/app/configurable_test.go:422

[2023-01-03T23:00:13.730Z]             	Error:      	Not equal: 

[2023-01-03T23:00:13.730Z]             	            	expected: false

[2023-01-03T23:00:13.730Z]             	            	actual  : true

[2023-01-03T23:00:13.730Z]             	Test:       	TestEncrypt/Good_-_Secrets_&_vector

[marcpfuller]

@bnevis-i, I resolved the failed testcase.

[codecov-commenter]

Codecov Report

Merging #1235 (8d39707) into main (a81394e) will decrease coverage by 0.29%.
The diff coverage is n/a.

❗ Current head 8d39707 differs from pull request most recent head fa918c9. Consider uploading reports for the commit fa918c9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   66.48%   66.19%   -0.30%     
==========================================
  Files          39       38       -1     
  Lines        3297     3227      -70     
==========================================
- Hits         2192     2136      -56     
+ Misses        961      951      -10     
+ Partials      144      140       -4     

Impacted Files	Coverage Δ
internal/app/configurable.go	62.77% <ø> (-1.51%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lenny-goodell]

@marcpfuller there is also a new binary file (internal/app/__debug_bin) that should not be added

[lenny-goodell]

Also need to remove the EncryptAES constant.

[marcpfuller]

I have removed the constant, and all its references.

[lenny-goodell]

LGTM. Thanks!