feat: Add option for Batch to merge results before sending. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when batching Metric data that has been transformed to Line Protocol format. closes edgexfoundry#1101 Signed-off-by: Leonard Goodell <[email protected]>
pkg/transforms/metrics.go
Outdated
| @@ -64,7 +64,8 @@ func (mp *MetricsProcessor) ToLineProtocol(ctx interfaces.AppFunctionContext, da | |||
| metric.Tags = append(metric.Tags, mp.additionalTags...) | |||
| } | |||
|
|
|||
| result := metric.ToLineProtocol() | |||
| // New line is needed if the resulting metric data is batched and sent in chunks to service like InfluxDB | |||
| result := metric.ToLineProtocol() + "\n" | |||
There was a problem hiding this comment.
use fmt.Sprintln() to avoid hard coded \n? :
Suggested change
| result := metric.ToLineProtocol() + "\n" | |
| result := fmt.Sprintln(metric.ToLineProtocol()) |
There was a problem hiding this comment.
I like it. THX!
Changed.
lenny-goodell
changed the title
Signed-off-by: Leonard Goodell <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
- Coverage 68.56% 68.49% -0.08%
==========================================
Files 37 37
Lines 3022 3034 +12
==========================================
+ Hits 2072 2078 +6
- Misses 822 827 +5
- Partials 128 129 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when batching Metric data that has been transformed to
Line Protocol format.
closes #1101
Signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)TBD
Testing Instructions
Build and run App Template service to generate metrics
Build ASC with this branch
Configure ASC metrics-profile with:
ExecutionOrder = "ToLineProtocol, Batch, HTTPExport"MergeOnSend = "true"in Batch function parametersRun ASC with metrics-profile with DEBUG logging
Verify HTTP Export reports
status is 204 No Contentin log fileNew Dependency Instructions (If applicable)