-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/backend kwargs json to netcdf #288
Feature/backend kwargs json to netcdf #288
Conversation
Hi @alexamici , can you review this PR which fixes issue #286 |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 95.30% 95.01% -0.29%
==========================================
Files 26 26
Lines 1938 1947 +9
Branches 229 230 +1
==========================================
+ Hits 1847 1850 +3
- Misses 61 66 +5
- Partials 30 31 +1
Continue to review full report at Codecov.
|
@EddyCMWF very nice feature! I have a few style comments:
|
My thinking was to improve performance by only importing modules if they are used, but happy to put the imports back to the top of the function. (Side note, |
My rule is: "readability over performance, unless there is a benchmark" 😄 |
@alexamici , sorry to change after your approval, I realised this should have a test in place, so have just added one |
Hi @EddyCMWF, thanks for adding the tests! I'm happy to merge this into master if you're finished now. |
Hi @iainrussell , yes I am finished now |
Allow backend kwargs to be provided in the to_netcdf executable, either via a json format string, or a path to a json file.
Fixes #286