WIP: Virtualized CodeGenerator Hierarchy #2639
Closed
+2,071
−2,026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhuiyan
reviewed
Jun 6, 2018
compiler/infra/Annotations.hpp
Outdated
| @@ -74,8 +74,10 @@ | |||
| // OMR_EXTENSIBLE | |||
| #if defined(__clang__) // Only clang is checking this macro for now | |||
| #define OMR_EXTENSIBLE __attribute__((annotate("OMR_Extensible"))) | |||
| #deine OMR_API __attribute__((annotate("OMR_API"))) | |||
There was a problem hiding this comment.
typo here would cause an error
There was a problem hiding this comment.
thanks, will fix it!
2 tasks
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
49793b1 to
a424309
Compare
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
3 times, most recently
from
182cb66 to
aec51ba
Compare
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
2 times, most recently
from
42b6b39 to
d756183
Compare
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
2 times, most recently
from
233a454 to
249ed4e
Compare
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
2 times, most recently
from
d2f1b9e to
253b3ec
Compare
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
253b3ec to
2322df9
Compare
samasri
requested review from
0xdaryl,
charliegracie,
fjeremic and
mstoodle
as code owners
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
90ea05e to
09bbd6f
Compare
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
The function has no implementation in OMR so it is causing compilation error Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Mistakenly removed self() from functions that do not belong to CodeGenerator classes Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Tests won't work on this commit since continueConstruction functin is still not called. So the constructor is technically missing part of its implementation Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
…ion and is never called in OMR Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
Signed-off-by: Samer AL Masri <[email protected]>
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
8da06d5 to
859aae5
Compare
After virtualizing the functions of CodeGenerator, I am removing all the self keywords This caused expressions like `TR::Compilation comp = comp()` to appear Since this is not allowed in C++, I change the `comp` variable name to `compilation` Signed-off-by: Samer AL Masri <[email protected]>
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
859aae5 to
ba88f14
Compare
This is part of the work to virtualize overridden functions in CodeGenerator and removing self() functions self()->insertInstructionPrefetches() is being called from OMR::CodeGenerator::doInstructionSelection() When removing self() from the call, the compiler complains that the function is not declared in the header Hence, I add it the function in OMR::CodeGenerator with an empty implementation Signed-off-by: Samer AL Masri <[email protected]>
samasri
force-pushed
the
Virtualizing-CodeGenerator
branch
from
1158448 to
c4f8c0d
Compare
After virtualizing the functions of CodeGenerator, I am removing all the self keywords This caused expressions like `TR::Compilation* machine = machine()` to appear Since this is not allowed in C++, I change the `machine` variable name to `thisMachine` Signed-off-by: Samer AL Masri <[email protected]>
|
Is this PR still active or has it been super-ceded by newer work? |
|
It is still active. This wiki page describes the current state of the project for which this PR belongs. |
|
This PR was created as part of a research project led by Dr. Sarah Nadi at the University of Alberta. I discussed the resolution of this family of PRs with Dr. Nadi last week. We agreed that since an effective alternate solution to address the extensibility requirements of the OMR compiler has not yet been determined (investigative work to do so will be part of a research project as described by Dr. Nadi at the Feb 25, 2019 OMR Architecture Meeting in #3607), plus the fact that the classes touched by these PRs represent only a partial and incomplete "revirtualization" solution, and that further progress on these PRs is unlikely in the near term, that we will close these PRs in the main OMR repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR_EXTENSIBLEfromCodeGeneratorclass declarationsself()from function calls ofCodeGeneratorSince virtualizing the
CodeGeneratorhierarchy requires changes from both, the OMR and OpenJ9, projects this PR is linked to a related one in openJ9 achieving the same purpose.Signed-off-by: Samer AL Masri [email protected]