Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unnamed module for split packages #2273

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Oct 17, 2022

Adopt the new preference to solve the problem 'The package xxx is accessible from more than one module'.

See: eclipse-jdt/eclipse.jdt.core#424

fix redhat-developer/vscode-java#2061
fix redhat-developer/vscode-java#1732
fix redhat-developer/vscode-java#862
fix redhat-developer/vscode-java#1619

Signed-off-by: Sheng Chen [email protected]

@jdneo
Copy link
Contributor Author

jdneo commented Oct 17, 2022

I was trying to add a test case but not succeeded. After the test projects are imported, it always does not have the expected error marker. Is that because the JDK used in test projects are faked? @rgrunber

@jdneo
Copy link
Contributor Author

jdneo commented Oct 17, 2022

test this please

Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change fixes the issue for me. Thanks for handling this upstream.

@rgrunber rgrunber added this to the End October milestone Oct 18, 2022
@rgrunber rgrunber merged commit f330315 into eclipse-jdtls:master Oct 18, 2022
@jdneo jdneo deleted the cs/unnamed-module branch October 19, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment