Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typo in gradle checksum mismatch error #2161

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

HandOfGod94
Copy link
Contributor

Currently, jdtls uses java.imports.gradle.wrapper.checksums to configure
allowed/disallowed gradle-wrappers. But the error is misleading as it
says java.import.gradle.wrapper.checksums.

It took me an evening to figure out, we need to use imports and not import for this config.

refer: https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L300

It's quite confusing. The docs are also misleading, as it has quite old info on the config which can be used.

Currently, jdtls uses `java.imports.gradle.wrapper.checksums` to configure
allowed/disallowed gradle-wrappers. But the error is misleading as it
says `java.import.gradle.wrapper.checksums`.
@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@rgrunber rgrunber added the bug label Jul 16, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Jul 16, 2022

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be easier to contribute in the future if you signed the Eclipse CLA, but as a 1-line change I think this should be acceptable.

Thanks again for finding this.

@rgrunber rgrunber merged commit 11d7561 into eclipse-jdtls:master Jul 16, 2022
@rgrunber rgrunber added this to the End July 2022 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants