Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract lambda body to method #2027

Closed
fbricon opened this issue Mar 16, 2022 · 1 comment · Fixed by #2044
Closed

Extract lambda body to method #2027

fbricon opened this issue Mar 16, 2022 · 1 comment · Fixed by #2044
Assignees
@snjeza
Labels
code-actions enhancement
Milestone
Early April 2022

Comments

@fbricon
Copy link
Contributor

fbricon commented Mar 16, 2022

Port JDT's "Extract lambda body to method" refactoring to jdt.ls. See https://www.eclipse.org/eclipse/news/4.23/jdt.php#extract-lambda-body-to-method
@snjeza snjeza self-assigned this Mar 16, 2022
@rgrunber
Copy link
Contributor

The relevant PR https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/188802 . This was just a combination of ExtractMethodRefactoring, and RefactoringCorrectionProposal. Those classes are in JDT-UI but we have our own copies. Since they haven't changed in that PR, we should be able to implement this by just copying the 30LOC from their QuickAssistProcessor.

@snjeza snjeza mentioned this issue Apr 1, 2022
Merged
@rgrunber rgrunber added this to the Early April 2022 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
code-actions enhancement
Projects
None yet
Milestone
Early April 2022
Development

Successfully merging a pull request may close this issue.

Extract lambda body to method snjeza/eclipse.jdt.ls
3 participants
@fbricon @snjeza @rgrunber