Add init containers in the che plugin model #14397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
davidfestal,
sleshchenko and
amisevsk
AndrienkoAleksandr
requested review from
l0rd,
metlos,
mshaposhnik,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
amisevsk
approved these changes
Aug 30, 2019
sleshchenko
approved these changes
Sep 2, 2019
| @@ -171,6 +176,15 @@ private void populateWorkspaceEnvVars( | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| private K8sContainerResolver toK8sContainerResolver( | |||
| CheContainer container, List<ChePluginEndpoint> endpoints) throws InfrastructureException { | |||
There was a problem hiding this comment.
InfrastructureException can not be thrown here
There was a problem hiding this comment.
Thanks, fixed
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr
force-pushed
the
addInitContainersInTheChePluginModel
branch
from
de1533e to
a4d4a7e
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
davidfestal
approved these changes
Sep 2, 2019
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add init containers in the che plugin model
What issues does this PR fix or reference?
#13387