Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS-SELENIUM] Fix HappyPath Java language server validation #13851

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

Remove checking of 'Starting Java Language Server' message in "Language server validation" part of HappyPath test. Sometimes HappyPath test fails because Java LS is started already.

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. team/che-qe labels Jul 15, 2019
@SkorikSergey SkorikSergey requested review from dmytro-ndp and rhopp July 15, 2019 14:40
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Jul 15, 2019

IMHO, for lightweight happy path tests we might need as few checks as possible to run it quickly and reliably.
checkJavaPathCompletion() indirectly checks if LS was initialized or not.

@SkorikSergey SkorikSergey merged commit 9cddc3e into master Jul 16, 2019
@SkorikSergey SkorikSergey deleted the fixHappyPathLsValidation branch July 16, 2019 07:59
@SkorikSergey SkorikSergey removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants