Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an Admin I want to customize Eclipse Che logo from the Custom Resource #22319

Closed
ibuziuk opened this issue Jun 23, 2023 · 8 comments · Fixed by eclipse-che/che-dashboard#907
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/next

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jun 23, 2023

Is your task related to a problem? Please describe

As an Admin I want to customize Eclipse Che logo from the Custom Resource

Describe the solution you'd like

spec:
  components:
    dashboard:
       logo:
         - base64data: <base64-encoded-data>
           mediatype: image/png

logo: a base64 encoded image. The base64data parameter contains the data and the mediatype specifies the type of image, eg. image/png or image/svg.

image

Inspired by the https://github.com/operator-framework/operator-lifecycle-manager/blob/4197455/Documentation/design/building-your-csv.md#operator-metadata

Describe alternatives you've considered

N/A

Additional context

part of #21571

@ibuziuk ibuziuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 23, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 23, 2023
@ibuziuk ibuziuk added sprint/next severity/P1 Has a major impact to usage or development of the system. area/dashboard area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 23, 2023
@ibuziuk ibuziuk moved this to 📋 Backlog in Eclipse Che Team A Backlog Jun 26, 2023
@ibuziuk ibuziuk moved this to 📅 Planned in Eclipse Che Team A Backlog Jun 28, 2023
@tolusha
Copy link
Contributor

tolusha commented Jul 4, 2023

The similar image [1] is used to configure OpenShift ConsoleLink.
But, the image url is the only way to set image for ConsoleLink object [2]

[1] https://github.com/eclipse-che/che-operator/blob/main/config/manager/manager.yaml#L96-L97
[2] https://docs.openshift.com/container-platform/4.9/rest_api/console_apis/consolelink-console-openshift-io-v1.html

@tolusha
Copy link
Contributor

tolusha commented Jul 6, 2023

What about this structure:

spec:
  components:
    dashboard:
       branding:
         logo:
           - base64data: <base64-encoded-data>
             mediatype: image/png

@l0rd
Copy link
Contributor

l0rd commented Aug 31, 2023

Related downstream issue

@ibuziuk ibuziuk moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Aug 31, 2023
@debkantap
Copy link

Is this feature available in 7:75 version. We tried it ..but looks like not working. pls advice..

Thanks

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 8, 2023

@debkantap yes, this feature works in 7.75 see eclipse-che/che-dashboard#907

@debkantap
Copy link

Thanks @ibuziuk for the quick reply ...It worked for me as well with the example. I missed the "'" single quote!!
Do you have some suggestion to convert the svg image to base64data pls?
Also is the loader image can also be changed using the same process, with rebuild..any clue?

@debkantap
Copy link

*without rebuild

@debkantap
Copy link

@ibuziuk ..now I could change logo and loader using both configurator and re-building the dashboard code. But not able to update the font color or background using the branding.css.
Do you have any clue?

Thanks & Regards
Debkanta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/next
Projects
None yet
6 participants