Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сlarify write error message on exposed-thing.writeMultipleProperties #470

Closed
maxim-s-barabash opened this issue Aug 20, 2021 · 4 comments
Closed

Comments

@maxim-s-barabash
Copy link

maxim-s-barabash commented Aug 20, 2021

v0.8.x

Now we have error text similar to

 Error: ExposedThing 'ThingTitle', failed to read properties [object Object]

There is a semantic error in the current code. read -> write

https://github.com/eclipse/thingweb.node-wot/blob/v0.8.x/packages/core/src/exposed-thing.ts#L391

    writeMultipleProperties(valueMap: WoT.PropertyWriteMap, options?: WoT.InteractionOptions): Promise<void> 
...
      .catch(err => {
-          reject(new Error(`ExposedThing '${this.title}', failed to read properties ` + valueMap));
+          reject(new Error(`ExposedThing '${this.title}', failed write multiple properties. ${err.message}`));
      });

PS: Am I posting these minor issues. Is this acceptable?

@relu91
Copy link
Member

relu91 commented Aug 20, 2021

PS: Am I posting these minor issues. Is this acceptable?

Yes, IMHO these are the trickiest things to notice. So thank you for reporting this here. If you are willing to contribute further, PRs are always welcomed.

@danielpeintner
Copy link
Member

@maxim-s-barabash do you want to provide a PR resolving the issue?

@maxim-s-barabash
Copy link
Author

At the moment I want to limit myself to posting issues.

@danielpeintner
Copy link
Member

At the moment I want to limit myself to posting issues.

No problem. Please take a look at #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants