Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileClient tests fail locally #1207

Closed
danielpeintner opened this issue Dec 21, 2023 · 1 comment · Fixed by #1213
Closed

FileClient tests fail locally #1207

danielpeintner opened this issue Dec 21, 2023 · 1 comment · Fixed by #1213
Assignees
Labels
binding-file Issues related to file protocol binding

Comments

@danielpeintner
Copy link
Member

I haven't seen issues with the recently added FileClient tests on our CI but I experience consistently failing tests on my windows box
Not sure if it is related to my setup

 File Client Implementation
    √ should be able to write and read files using URI scheme file:/// with Content-Type application/json
    √ should be able to write and read files using URI scheme file:/// with no Content-Type
    1) should be able to write and read files using URI scheme file:/// with Content-Type text/plain
    √ should be able to write and read files using URI scheme file:// with Content-Type application/json
    √ should be able to write and read files using URI scheme file:// with no Content-Type
    2) should be able to write and read files using URI scheme file:// with Content-Type text/plain


  4 passing (20ms)
  2 failing

  1) File Client Implementation
       should be able to write and read files using URI scheme file:/// with Content-Type text/plain:

      AssertionError: expected '' to deeply equal 'Lorem ipsum dolor sit amet.'
      ...

  2) File Client Implementation
       should be able to write and read files using URI scheme file:// with Content-Type text/plain:

      AssertionError: expected '' to deeply equal 'Lorem ipsum dolor sit amet.'

@relu91 since you are on Windows also. Do you have issues on your machine as well?

@danielpeintner danielpeintner added the binding-file Issues related to file protocol binding label Dec 21, 2023
@JKRhb
Copy link
Member

JKRhb commented Dec 21, 2023

The test also fail for me sometimes (I am currently using a Mac), so this is a general problem :/ I will try to come up with a fix for the issue, sorry for the inconvenience this causes :/

@JKRhb JKRhb self-assigned this Dec 21, 2023
@JKRhb JKRhb linked a pull request Jan 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-file Issues related to file protocol binding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants