-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible contribution for a new preference editor #6985
Comments
It would be good to have the same UI as in VS Code. |
Thanks for the fast feedback! Great that there is interest in such a preference editor. |
Hi @lucas-koehler , just wanted to mention that my team has developed a Preferences UI for Theia that has a very similar UI as VSCode. It includes fuzzy searching and the ability to jump to sections from the side navigation. We have been using it internally and find it very nice. We were planning on upstreaming after we received approval to do so internally. I wanted to see if you were interested in viewing that as a draft PR before you continue working on the feature separately? We could have that up by next Friday (February 7) or possibly sooner. It's up to you if you want to continue with your implementation, but I thought I would mention it as to avoid doing duplicate work :) |
@danieltomasku wow, I would like to see a PR ) |
Hi @danieltomasku, thanks for letting me know. I indeed would like to see the draft PR as your implementation already sounds quite mature and avoiding duplicate work is always good :) |
@lucas-koehler @akosyakov Sounds good. We'll work on cleaning it up internally, then we should be able to have a PR up by Friday. |
@danieltomasku You can open it anyway and ask for the community help to clean up certain aspects. |
@lucas-koehler @akosyakov the PR, promised by @danieltomasku, has been created: #7105 . Please have a look and give feedback. |
resolved with #7105 |
Hello Theia community,
would you be interested in a contribution for a tree-master-detail based preference editor?
The tree shows the preference categories on the left side. The detail renders the selected category's preferences on the right side.
Thus, the main difference to the current editor is that the preferences are edited via suitable controls
in the detail view instead of showing the raw JSON on the right side. The following screenshots shows a first, minimal demo implementation.
Are you interested in a contribution of such a preference editor?
The text was updated successfully, but these errors were encountered: