Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible contribution for a new preference editor #6985

Closed
lucas-koehler opened this issue Jan 28, 2020 · 9 comments
Closed

Possible contribution for a new preference editor #6985

lucas-koehler opened this issue Jan 28, 2020 · 9 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences proposal feature proposals (potential future features)

Comments

@lucas-koehler
Copy link
Contributor

Hello Theia community,

would you be interested in a contribution for a tree-master-detail based preference editor?
The tree shows the preference categories on the left side. The detail renders the selected category's preferences on the right side.
Thus, the main difference to the current editor is that the preferences are edited via suitable controls
in the detail view instead of showing the raw JSON on the right side. The following screenshots shows a first, minimal demo implementation.

image

image

Are you interested in a contribution of such a preference editor?

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences proposal feature proposals (potential future features) labels Jan 28, 2020
@akosyakov
Copy link
Member

It would be good to have the same UI as in VS Code.

@lucas-koehler
Copy link
Contributor Author

Thanks for the fast feedback! Great that there is interest in such a preference editor.
We'll go ahead and prepare a draft PR for further discussion then.
I had a look at the code of VSCode's preference editor and it doesn't seem to be a component that can easily be reused.
However, we'll try to align the UI and make it compatible from a styling point of view.

@danieltomasku
Copy link
Contributor

Hi @lucas-koehler , just wanted to mention that my team has developed a Preferences UI for Theia that has a very similar UI as VSCode. It includes fuzzy searching and the ability to jump to sections from the side navigation. We have been using it internally and find it very nice. We were planning on upstreaming after we received approval to do so internally. I wanted to see if you were interested in viewing that as a draft PR before you continue working on the feature separately? We could have that up by next Friday (February 7) or possibly sooner. It's up to you if you want to continue with your implementation, but I thought I would mention it as to avoid doing duplicate work :)

@akosyakov
Copy link
Member

@danieltomasku wow, I would like to see a PR )

@lucas-koehler
Copy link
Contributor Author

Hi @danieltomasku, thanks for letting me know. I indeed would like to see the draft PR as your implementation already sounds quite mature and avoiding duplicate work is always good :)

@danieltomasku
Copy link
Contributor

@lucas-koehler @akosyakov Sounds good. We'll work on cleaning it up internally, then we should be able to have a PR up by Friday.

@akosyakov
Copy link
Member

@danieltomasku You can open it anyway and ask for the community help to clean up certain aspects.

@marcdumais-work
Copy link
Contributor

@lucas-koehler @akosyakov the PR, promised by @danieltomasku, has been created: #7105 . Please have a look and give feedback.

@akosyakov
Copy link
Member

resolved with #7105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

5 participants