Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini-browser] mini-browser not focused correctly #5560

Open
vince-fugnitto opened this issue Jun 21, 2019 · 4 comments
Open

[mini-browser] mini-browser not focused correctly #5560

vince-fugnitto opened this issue Jun 21, 2019 · 4 comments
Labels
bug bugs found in the application mini-browser issues related to the mini-browser

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jun 21, 2019

Description

Currently, when the preview mini-browser editor is used to view an image, clicking within the editor does not set the focus to the entire editor which results in odd behaviors such as the inability to open the quick-command-palette to perform actions. Instead, like the preview for markdown, selecting within the editor should set the focus to the editor itself.

Steps to Reproduce

  1. open an svg file as a preview.
  2. click within the svg file.
  3. attempt to open the quick-commands (F1)

Additional Info

Theia c02c6e2
Ubuntu 16.04
Chrome v74.0.3729.6

@vince-fugnitto vince-fugnitto added bug bugs found in the application preview issues related to the preview labels Jun 21, 2019
@vince-fugnitto vince-fugnitto changed the title [preview] preview editor not focused correctly [mini-browser] mini-browser not focused correctly Jun 21, 2019
@vince-fugnitto vince-fugnitto added the mini-browser issues related to the mini-browser label Jun 21, 2019
@vince-fugnitto
Copy link
Member Author

Potentially related #4368

@vince-fugnitto
Copy link
Member Author

Related to #5521

@vince-fugnitto vince-fugnitto removed the preview issues related to the preview label Jun 28, 2019
@akosyakov
Copy link
Member

I think we need iframe widget, which handles typical iframe issues and particularly can forward focus/blur events to the host window from iframe window. MiniBrowser and WebView should be reimplemented by using it.

@akosyakov
Copy link
Member

I think we should do #6562 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application mini-browser issues related to the mini-browser
Projects
None yet
Development

No branches or pull requests

2 participants