Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin-API] Improve window.createQuickPick() #5059

Open
11 of 13 tasks
vinokurig opened this issue May 2, 2019 · 4 comments
Open
11 of 13 tasks

[Plugin-API] Improve window.createQuickPick() #5059

vinokurig opened this issue May 2, 2019 · 4 comments
Labels
help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

vinokurig commented May 2, 2019 •
edited by vince-fugnitto
Loading

Description

window.createQuickPick() introduced in #5012 have only the base functionality, reused from QuickOpenExtImpl:

  • set items
  • show()

Functionality that is not supported by QuickOpenExtImpl but declared in QuickPick:

  • busy (If the UI should show a progress indicator)
  • get / set buttons
  • step / totalSteps (An optional current / total step count)
  • enabled (If the UI should allow for user input)
  • multiple selection
  • ignoreFocusOut (If the UI should stay open even when loosing UI focus)
  • matchOnDescription (If the filter text should also be matched against the description of the items)
  • matchOnDetail (If the filter text should also be matched against the detail of the items)
  • value (Current value of the filter text)
  • hide()
  • onDidHide (An event signaling when this input UI is hidden)
  • onDidChangeActive (An event signaling when the active items have changed)
  • onDidChangeSelection (An event signaling when the selected items have changed)
@vinokurig vinokurig mentioned this issue May 2, 2019
Merged
@akosyakov akosyakov added vscode issues related to VSCode compatibility help wanted issues meant to be picked up, require help labels May 3, 2019
@tetchel tetchel mentioned this issue Jun 17, 2019
Closed
@akosyakov
Copy link
Member

@vinokurig Could you please turn points into check boxes? and mark what was addressed?

@tetchel
Copy link
Contributor

tetchel commented Sep 19, 2019 •
edited
Loading

I can verify most of these work in 0.10, I do see this quickpick bug -> #6221

@tetchel
Copy link
Contributor

tetchel commented Nov 20, 2019

Please implement the busy option!

@akosyakov
Copy link
Member

Please implement the busy option!

We have the progress service now, implemented by @AlexTugarev which can run blueish progress bar on any HTML Element. It should be feasible to implement, but someone has to step up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @vinokurig @tetchel