rust-analyzer fill matching arms does not work in theia but works in vscode

[hsnoil]

Bug Description:

When using rust-analyzer extension, the fill match arms does not work on TheiaIDE appimage, but it works fine on vscode. Other rewrites work, just not fill match arms

Steps to Reproduce:

1. Make sure cargo is installed and rust-analyzer extension
2. create a new project cargo new test1
3. Open test1 folder in Theia and put this in src/main.rs:

enum Pet {
    Cat,
    Dog
}

fn main() {
    let pet = Pet::Cat;
    match pet {
        
    }

}

4. pet in match pet { line should highlight as an error, mouse over it and scroll down to Quick fix... or ctrl+. and click on Fill match arms, nothing happens

Additional Information

It should give this:

match pet {
        Pet::Cat => todo!(),
        Pet::Dog => todo!(),
    }

• Operating System: Linux
• Theia Version: 1.51.0

[JonasHelming]

Thank you for the report. Could you paste a link to the to extensions on openVSX and ideally also the versions of the extensions you are using?

[hsnoil]

@JonasHelming Sure

https://open-vsx.org/extension/rust-lang/rust-analyzer

v0.4.2044

[JonasHelming]

Thanks, you also mention "Cargo" needs to be installed, could you provide the details there, too?

[hsnoil]

Cargo comes with Rust(which is what is also needed):

https://www.rust-lang.org/tools/install

[tsmaeder]

@hsnoil what version of TheiaIDE are you using?

[msujew]

@tsmaeder In the initial post they mention:

Operating System: Linux
Theia Version: 1.51.0

[hsnoil]

I think I may have narrowed down the problem.

The issue is likely related to doing a set of a SnippetTextEdit

This is the part where it fails:

   const [uri, edits] = unwrapUndefinable(editEntries[0]);
        const editor = await editorFromUri(uri);
        if (editor) {
            edit.set(uri, removeLeadingWhitespace(editor, edits));
            await vscode.workspace.applyEdit(edit);
        }

https://github.com/rust-lang/rust-analyzer/blob/master/editors/code/src/snippets.ts

on vscode the applyEdit returns true, while Theia returns false.

Doing a few tests, if I use a TextEdit, it works (but then you lose templates of the SnippetTextEdit)

Edit:
I was able to find a workaround by modifying rust-analyzer to use insertSnippet instead. But the underlying issue is still that set with SnippetTextEdit and then using applyEdit doesn't work.

[hsnoil]

I notice there are some differences for set between theia and vscode. Not sure if that is the issue as the pc I am on is has too little space which won't let me compile Theia:

 this._edits.push({ _type: FileEditType.Snippet, uri, range: edit.range, edit, metadata });

theia/packages/plugin-ext/src/plugin/types-impl.ts

Line 1951 in 8b3ea1c

this._edits.push({ _type: FileEditType.Snippet, uri, range: edit.range, edit, metadata });

this._edits.push({ _type: FileEditType.Snippet, uri, range: edit.range, edit: edit.snippet, metadata, keepWhitespace: edit.keepWhitespace });

https://github.com/microsoft/vscode/blob/32a41e158d04c9777522dc567574f2a74b8f2bf9/src/vs/workbench/api/common/extHostTypes.ts#L944

As you can see, edit should be equal to edit.snippet but it ends up as edit: { snippet: edit.snippet }