Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] API gap: Theia master vs. VS Code 1.77.0 #12375

Closed
2 tasks done
Tracked by #12530
rschnekenbu opened this issue Apr 4, 2023 · 7 comments
Closed
2 tasks done
Tracked by #12530

[vscode] API gap: Theia master vs. VS Code 1.77.0 #12375

rschnekenbu opened this issue Apr 4, 2023 · 7 comments
Labels
epic epic issues consisting of multiple smaller issues vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

This bug tracks the differences between current master Theia VS Code API and VS Code 1.77.0:

@vince-fugnitto vince-fugnitto added epic epic issues consisting of multiple smaller issues vscode issues related to VSCode compatibility labels Apr 4, 2023
@rschnekenbu
Copy link
Contributor Author

As the 1.76 and 1.77 are now resolved, I pushed a new PR to bump the API version.
@vince-fugnitto should we also update the built-ins?

@marcdumais-work
Copy link
Contributor

Hi @rschnekenbu - we are caching-up fast, thanks for your contributions in that area!

As recently discussed at the dev-meeting (I think), we should take into consideration what proposed API from vscode, we may be missing at least in stub form, that's used (implicitly required) by some of the vscode built-in extensions (v1.77.0 in this case). This will help avoid issues when more recent built-ins are published, if Theia already "supports" the proposed API they need.

I will open an issue tomorrow with the details about such problems we found with built-ins 1.77.0 used against master, that we may consider addressing before bumping Theia's API version.

Thanks,
Marc

@rschnekenbu
Copy link
Contributor Author

Hi @marcdumais-work, thanks a lot for your quick feedback! I have indeed seen the discuss #12450.
I was currently checking what is done in the vscode-builtins, and also checking whether theia-vscodecov tool could be of any use there, as a one shot or on a build job.
I'll add an entry in the discuss, that should be more appropriate than here.

@marcdumais-work
Copy link
Contributor

I was currently checking what is done in the vscode-builtins

@rschnekenbu if you had not seen it yet, please see this wiki, I have been working on recently, for more info about the built-ins: https://github.com/eclipse-theia/vscode-builtin-extensions/wiki/Produce-and-Publish-the-set-of-vscode-built-in-extensions

@marcdumais-work
Copy link
Contributor

We have the 3 following issues and another one coming soon affecting vscode.simple-browser:

ProfileContentHandler (affecting  built-in vscode.configuration-editing) :
#12520

EditSessionIdentityProvider (affecting vscode.git)
#12521

TerminalQuickFixProvider (affecting vscode.npm):
#12522

@alvsan09
Copy link
Contributor

Here is the fourth one:

ExternalUripener (affecting vscode.simple-browser)
#12523

@vince-fugnitto
Copy link
Member

Closed thanks to #12516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic epic issues consisting of multiple smaller issues vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants