Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint does not consider extension installation recommendations #122

Closed
JonasHelming opened this issue Jul 14, 2021 · 6 comments
Closed
Assignees
Milestone

Comments

@JonasHelming
Copy link
Contributor

Bug Description:

If a repository recommends extensions to be installed via extensions.json, Theia blueprint does not suggest to install them.

Steps to Reproduce:

Checkout a repository with recommended extensions, e.g. https://github.com/eclipse-theia/theia
No recommendations are shown.
Should suggest eslint, see https://github.com/eclipse-theia/theia/blob/master/.vscode/extensions.json

@vince-fugnitto
Copy link
Member

@JonasHelming it should be available when bumping the theia version eclipse-theia/theia#9043.

@JonasHelming
Copy link
Contributor Author

Great! Let us leave this open until then, I assigned a label to keep track

@JonasHelming JonasHelming added this to the Beta 2 milestone Jul 16, 2021
@vince-fugnitto
Copy link
Member

Closed thanks to #141.

@JonasHelming
Copy link
Contributor Author

@vince-fugnitto : Have you verified this in the Blueprint build or only upstream?

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Aug 13, 2021

@vince-fugnitto : Have you verified this in the Blueprint build or only upstream?

During the review, please feel free to confirm as well: #141 (review).

@marcdumais-work
Copy link
Contributor

During the review, please feel free to confirm as well: #141 (review).

I have not re-tested this, but I have confirmed that the new Blueprint installers, based on Theia v1.16.0, were correctly deployed. (linux: https://www.eclipse.org/downloads/download.php?file=/theia/latest/linux/TheiaBlueprint.AppImage&r=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants