Welcome Page, About Dialog, Additional Open VSX Plugins

[jfaltermeier]

What it does

• This adds a welcome page and an about dialog that explain the purpose of the blueprint application and provides useful links for the user (documentation, how to report bugs, ..)
• Adds additional open vsx plugins in order to achieve good support for JavaScript, Typescript, and Java, and additional useful tools like markdown.
• This increases the version to 1.9.1 so that we may test updating existing 1.9.0 application

Closes #5
Closes #9
Closes #10

Contributed on behalf of STMicroelectronics

How to test

Build application and review getting started page and about dialog.
Open a workspace and test language support

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[marcdumais-work]

@vince-fugnitto would you have a look at the branding aspect of this PR?

[vince-fugnitto]

I have some general comments about the pull-request:

• the about dialog is not responsive and does not display properly for smaller viewports.
• the styling of the custom getting-started can be improved (especially when verifying responsiveness).
• we should think of updating the applicationName for the application:
  • this will be used for example in the window title.
  • we will no longer need to hardcode theia blueprint but can rather read the applicationName once.
  • we can store user level configurations under the custom name (user home - ~/.theia-blueprint) rather than the upstream default ~/.theia.

[koegel]

I have some general comments about the pull-request:

Thank you for your feedback, all good and valid points!

• the about dialog is not responsive and does not display properly for smaller viewports.
• the styling of the custom getting-started can be improved (especially when verifying responsiveness).
• we should think of updating the applicationName for the application:
  • this will be used for example in the window title.
  • we will no longer need to hardcode theia blueprint but can rather read the applicationName once.

I opened an issue for these points: #27
In addition there is already a ticket to update the application name property: #25

• we can store user level configurations under the custom name (user home - ~/.theia-blueprint) rather than the upstream default ~/.theia.

I added this to the existing tickets to update all config files: #25

To me it seems none of this is a blocker and we can go ahead with the PR?

[marcdumais-work]

To me it seems none of this is a blocker and we can go ahead with the PR?

Absolutely. I'll have a quick look at the latest version and approve ASAP.
@vince-fugnitto everything good for you?

[marcdumais-work]

This is almost ready. I do not see that the comment about adding the node-debug extensions had been resolved. I'm also ok with opening an issue or adding this item to an existing issue, as you see fit

[vince-fugnitto]

@vince-fugnitto everything good for you?

Everything looks fine as an initial update to about and getting-started for me 👍

[marcdumais-work]

@vince-fugnitto then can you please approve?

[jfaltermeier]

This is almost ready. I do not see that the comment about adding the node-debug extensions had been resolved. I'm also ok with opening an issue or adding this item to an existing issue, as you see fit

This is included by now, see line 127, 128 (https://github.com/eclipse-theia/theia-example/pull/24/files#diff-60e7eeb6bc8be48e5693ebc9be980d76bb7973ab861bf167c666b519d437f501)
The build is also green now (Linux build is a bit brittle and the windows node sometimes loses connection :-()

[marcdumais-work]

LGTM, thanks @jfaltermeier

[koegel]

Thanks for reviewing and merging!

[jfaltermeier]

Thank you. @thegecko Could you please restart the master build?
Unfortunately the last build failed with a 403 when fetching from github: https://ci.eclipse.org/theia/job/theia-example/job/master/