Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Theia default package for installer #5

Closed
koegel opened this issue Nov 26, 2020 · 10 comments · Fixed by #24
Closed

Define Theia default package for installer #5

koegel opened this issue Nov 26, 2020 · 10 comments · Fixed by #24

Comments

@koegel
Copy link

koegel commented Nov 26, 2020

We need to define what to include in terms of extensions and plugins.

Initial suggestion:

  • Edit, Launch and Debug JS, Typescript and Java Code
  • Edit XML and JSON files with syntax highlighting
  • Git Integration (Clone, push, pull, commit, checkout, diff)

In addition we could add some features to showcase the flexibility of the Theia platform:

  • A code generator based on Xtend
  • A textual editor for an XText-based DSL
  • A form-based editor (e.g. for editing bug reports)
  • A graphical editor or visualization (e.g. editing diagrams for Ecore)
@koegel
Copy link
Author

koegel commented Nov 26, 2020

We (EclipseSource) intend to work on this on behalf of ST Microelectronics.

jfaltermeier added a commit to jfaltermeier/theia-example that referenced this issue Dec 2, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for eclipse-theia#5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)
jfaltermeier added a commit to jfaltermeier/theia-example that referenced this issue Dec 2, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for eclipse-theia#5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to jfaltermeier/theia-example that referenced this issue Dec 2, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for eclipse-theia#5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier referenced this issue in eclipsesource/theia-example Dec 3, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for #5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier referenced this issue in eclipsesource/theia-example Dec 14, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for #5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier referenced this issue in eclipsesource/theia-example Dec 15, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for #5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier referenced this issue in eclipsesource/theia-example Dec 17, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for #5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
jfaltermeier referenced this issue in eclipsesource/theia-example Dec 18, 2020
* add preinstalled theiaPlugins to package-json of electron-app (preparation for #5)
* add lerna to enable a multi-package repository for electron app + customization packages
* add a custom main js that sets the environment variable for preinstalled plugins
* add a customization module for the installer at theia-example-updater. This may be used to enable updates (eclipse-theia#13), to customize the about dialog (eclipse-theia#10), and to customize the getting started page (eclipse-theia#9)

Signed-off-by: Johannes Faltermeier <[email protected]>
Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
@koegel
Copy link
Author

koegel commented Jan 7, 2021

The current product is configured so it can be used to edit, run and debug JavaScript, Typescript and Java code. We decided to aim for a product that contains all required features to be able to work on the Theia code-base.

@marcdumais-work
Copy link
Contributor

edit, run and debug JavaScript, Typescript and Java code. We decided to aim for a product that contains all required features to be able to work on the Theia code-base.

That's a very good start, and the list of "included by default" extensions can be enhanced at any time.

@marcdumais-work
Copy link
Contributor

As an enhancement you can consider including the full set of vscode built-ins (minus exceptions). Usually the Microsoft or 3rd party extensions will not re-implement features provided by built-ins. So you might e.g. have a user install the MS python extension, have LS support and other advanced features but no syntax highlight because the vscode.python extension, that provides the TExtmate grammar, is missing. The user could install it, if they know-to.

@marcdumais-work
Copy link
Contributor

cc: @vince-fugnitto

@koegel
Copy link
Author

koegel commented Jan 18, 2021

As an enhancement you can consider including the full set of vscode built-ins (minus exceptions). Usually the Microsoft or 3rd party extensions will not re-implement features provided by built-ins. So you might e.g. have a user install the MS python extension, have LS support and other advanced features but no syntax highlight because the vscode.python extension, that provides the TExtmate grammar, is missing. The user could install it, if they know-to.

Good point. How can we include all of them? Is there a list somewhere?

@marcdumais-work
Copy link
Contributor

Good point. How can we include all of them? Is there a list somewhere?

No, I do not think so. I think we should have a way to list them. Would you open an issue on the vscode-builtin-extensions repo about this?

For a quick list, see the main repo's example app. The only thing is that their versions have not been updated in a while.
https://github.com/eclipse-theia/theia/blob/master/package.json#L86-L154

@koegel
Copy link
Author

koegel commented Jan 19, 2021

Ok, thanks.
And sure, I opened an issue.

@koegel
Copy link
Author

koegel commented Jan 19, 2021

To add all built-ins to blueprint I also created an issue separate from this one.

marcdumais-work pushed a commit that referenced this issue Jan 26, 2021
* Add additional plugins
* Update plugin versions

Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
@marcdumais-work
Copy link
Contributor

Good point. How can we include all of them? Is there a list somewhere?

No, I do not think so.

There is now an easy way to add all built-ins, in one operation - the built-in extensions pack:
https://open-vsx.org/extension/eclipse-theia/builtin-extension-pack/1.50.0

There are still things to iron-out, like we'd probably want the extensions to be fetched/installed at build-time rather than runtime. See this draft PR (not to be merged at this time), the first step in using the pack.
#93

sdirix pushed a commit to sdirix/theia-blueprint that referenced this issue Nov 12, 2024
…se-version-0.1.2

Update scorpio with release version 0.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants