Theia 1.20.0, yarn upgrade #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I think at least one unintended changes has seeped-in. Please hold-off on reviewing for the moment. |
marcdumais-work
force-pushed
the
theia-1.20.0
branch
4 times, most recently
from
a0ddfc5 to
04bd22e
Compare
|
Ok, should be good now. |
jfaltermeier
reviewed
Dec 1, 2021
jfaltermeier
approved these changes
Dec 1, 2021
|
@jfaltermeier @vince-fugnitto about the version of |
Fixes #181 Signed-off-by: Marc Dumais <[email protected]>
`yarn upgrade` happily updated to a newer version of this dependency, but
newer versions did not play well at runtime, causing the AppImage package
to fail at startup (1). I tried a few versions, starting with newer ones, and
pinned the first one that worked.
(1):
```bash
theia-blueprint$ ./applications/electron/dist/TheiaBlueprint.AppImage
Failed to start the electron application.
Error: Cannot find module 'fs/promises'
Require stack:
- /tmp/.mount_TheiaBXVxquD/resources/app/node_modules/electron-updater/out/AppUpdater.js
- /tmp/.mount_TheiaBXVxquD/resources/app/node_modules/electron-updater/out/main.js
- /tmp/.mount_TheiaBXVxquD/resources/app/node_modules/theia-blueprint-updater/lib/electron-main/update/theia-updater-impl.js
- /tmp/.mount_TheiaBXVxquD/resources/app/node_modules/theia-blueprint-updater/lib/electron-main/update/theia-updater-main-module.js
- /tmp/.mount_TheiaBXVxquD/resources/app/src-gen/frontend/electron-main.js
- /tmp/.mount_TheiaBXVxquD/resources/app/scripts/theia-electron-main.js
-
at Module._resolveFilename (internal/modules/cjs/loader.js:797:17)
at Function.o._resolveFilename (electron/js2c/browser_init.js:281:681)
at Module._load (internal/modules/cjs/loader.js:690:27)
at Function.Module._load (electron/js2c/asar.js:769:28)
at Module.require (internal/modules/cjs/loader.js:852:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object.<anonymous> (/tmp/.mount_TheiaBXVxquD/resources/app/node_modules/electron-updater/out/AppUpdater.js:8:20)
at Module._compile (internal/modules/cjs/loader.js:967:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
at Module.load (internal/modules/cjs/loader.js:815:32) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/tmp/.mount_TheiaBXVxquD/resources/app/node_modules/electron-updater/out/AppUpdater.js',
'/tmp/.mount_TheiaBXVxquD/resources/app/node_modules/electron-updater/out/main.js',
'/tmp/.mount_TheiaBXVxquD/resources/app/node_modules/theia-blueprint-updater/lib/electron-main/update/theia-updater-impl.js',
'/tmp/.mount_TheiaBXVxquD/resources/app/node_modules/theia-blueprint-updater/lib/electron-main/update/theia-updater-main-module.js',
'/tmp/.mount_TheiaBXVxquD/resources/app/src-gen/frontend/electron-main.js',
'/tmp/.mount_TheiaBXVxquD/resources/app/scripts/theia-electron-main.js',
undefined
]
}
```
Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
theia-1.20.0
branch
from
04bd22e to
d0e4cef
Compare
|
I had done a quick job, finding a working version of |
|
Thanks for the review comments. I will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Update Blueprint's underlying framework, Theia, to v1.20.0 and run
yarn upgradeto update various dependencies to the latest possible, as per their requested version range.Vulnerabilities (
yarn audit):Before this PR:
After this PR (yarn upgrade):
How to test
Build and run
Blueprint, both in-place and in packaged form. Make sure everything still seems to work.Review checklist
Reminder for reviewers