Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Implement pre-commit hooks #352

Open
nicu1989 opened this issue Feb 12, 2025 · 2 comments
Open

git: Implement pre-commit hooks #352

nicu1989 opened this issue Feb 12, 2025 · 2 comments
Labels
good first issue Good for newcomers infrastructure General Score infrastructure topics

Comments

@nicu1989
Copy link
Contributor

It would be nice to have some checks done also at commit level, before push.
At least the gitlint would be good but also format check.

Also document the necessary steps required by contributor(if any).

@nicu1989 nicu1989 added the infrastructure General Score infrastructure topics label Feb 12, 2025
@nicu1989 nicu1989 added the good first issue Good for newcomers label Feb 12, 2025
@MaximilianSoerenPollak
Copy link
Contributor

MaximilianSoerenPollak commented Feb 17, 2025

Pre-push makes sense, pre-commit doesn't in my opinion, as then it would run even when you aren't 'ready' for it.
If you have it commited then I guess you 'signal' that at least for now you are done working on it and the stuff could run.

Edit: I guess the hook would be called commit-msg for the git lint stuff, and for the rest probably something else.

Relevant url: git docs

@AlexanderLanin
Copy link
Member

AlexanderLanin commented Feb 17, 2025

Hint: pre-commit.com is nicer than creating git-commands manually

Open points:

  • pre commit or pre push?
  • what exactly do we check?

Note: specifically, for gitlint see issue TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers infrastructure General Score infrastructure topics
Projects
Development

No branches or pull requests

3 participants