Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property autocomplete insertion bug #10

Closed
mickaelistria opened this issue Apr 3, 2020 · 2 comments
Closed

Property autocomplete insertion bug #10

mickaelistria opened this issue Apr 3, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@mickaelistria
Copy link
Contributor

mickaelistria commented Apr 3, 2020

From AObuchow/lsp4xml-extensions-maven#21

When trying to get autocomplete for properties, I seem to have to type in a character that's part of the completion (eg {) to get the autocompletions to appear. However when inserting, the typed in { doesn't get removed/accounted for, resulting in incorrect syntax.

For property autocomplete (and possibly other completions), we should take into account what the user has already written and possible replace or modify the existing text using the selected completion.

Demo: https://photos.app.goo.gl/vXVLBM8AdcmD4Qz48

@AObuchow
Copy link
Contributor

AObuchow commented Jun 8, 2020

This might have been fixed in 3585971 but it needs to be verified.

@mickaelistria
Copy link
Contributor Author

I think it's not really a bug. There is no compelling reason to assume a simple { is to be interpreted as ${ in general. I tried a bit and didn't spot any oddity with property insertion, so let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants