Improve extends/implements completion #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix 29 test cases |
mickaelistria
force-pushed
the
dom-with-javac
branch
from
c906abc to
b53a413
Compare
datho7561
force-pushed
the
dom-with-javac-improve-extends-completion
branch
from
5c5d36a to
c4f652b
Compare
|
I think some (but not all) of the test cases this fixes were also fixed by b53a413 |
datho7561
force-pushed
the
dom-with-javac-improve-extends-completion
branch
from
c4f652b to
105d118
Compare
|
I don't know why there less new passes on the server, locally there are 30 for me. Hopefully rerunning will address this. |
robstryker
force-pushed
the
dom-with-javac
branch
from
9fb5c87 to
d568f49
Compare
datho7561
force-pushed
the
dom-with-javac-improve-extends-completion
branch
from
105d118 to
7897680
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
08ec5cf to
10fe71a
Compare
- precalculate extends or implements info
- When there is no prefix, suggest types declared in the same class,
eg. suggest `MyInterface` in the following snippet
```java
public class MyClass implements | {
}
interface MyInterface {}
```
- Better recovery of bindings for classes with incomplete extends or
implements sections
- previously the binding key was always `*`, which caused many that
relied on the binding key to break
- Use ExtendsOrImplements info filtering in more places
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
dom-with-javac-improve-extends-completion
branch
from
7897680 to
5965674
Compare
|
The discrepancy in my results is related to one of these: update: nope it was becayse there wasn't running |
|
🥳 😍 Fixes 12 🥳 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyInterfacein the following snippetBetter recovery of bindings for classes with incomplete extends or implements sections
*, which caused many that relied on the binding key to breakUse ExtendsOrImplements info filtering in more places